QVAC-20837 fix: register built-in plugins for Bare examples; clarify Bare docs and error#2640
Merged
opaninakuffo merged 4 commits intoJun 18, 2026
Conversation
…Bare docs and error
- bare-bootstrap.js: use bare-process/bare-path; load the default worker
entry (dist/server/worker.js) to register the built-in plugin set before
the example runs (initializeWorkerCore is idempotent). Warn if not built.
- Rewrite WORKER_PLUGINS_NOT_REGISTERED message: register via plugins([...])
/ registerPlugin(...) on Bare, import each plugin from its subpath, and
recommend @qvac/bare-sdk for direct Bare usage.
- Docs: @qvac/sdk README clarifies Bare needs explicit registration;
@qvac/bare-sdk README adds a Connection lifecycle section (close(),
unloadModel({ autoClose })).
…gistration docs - Add "Runtime registration on Bare" section to the Plugin system page, distinguishing bundle-time plugin selection from runtime registration. - Link the WORKER_PLUGINS_NOT_REGISTERED message to the new doc anchor.
Explain that the harness loads the default worker only to run the registration-free bundled examples (the @qvac/sdk "full defaults" path), and that explicit/selective assembly is @qvac/bare-sdk's model.
lauripiisang
approved these changes
Jun 18, 2026
arun-mani-j
approved these changes
Jun 18, 2026
NamelsKing
approved these changes
Jun 18, 2026
Contributor
Author
|
review |
Contributor
Tier-based Approval Status |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
bun run bare:examplefailed withWORKER_PLUGINS_NOT_REGISTERED. Bare runs in-process with no spawned worker, so (unlike Node/Expo) nothing auto-registers the built-in plugins.bare-bootstrap.jsharness couldn't even run on Bare — it imported Node'sprocess/pathinstead ofbare-process/bare-path.WORKER_PLUGINS_NOT_REGISTEREDmessage pointed at an unresolvable import path (@qvac/sdk/server/bare/plugins) and didn't explain the Bare-specific contract.@qvac/sdkon Bare requires explicit plugin registration, nor how to tear down long-lived connections.📝 How does it solve it?
bare-bootstrap.js: usebare-process/bare-path, and load the default worker entry (dist/server/worker.js) before the example so the built-in plugin set is registered (initializeWorkerCoreis idempotent). Warns if the worker entry isn't built.WORKER_PLUGINS_NOT_REGISTEREDmessage: register viaplugins([...])/registerPlugin(...)on Bare, import each plugin from its subpath (e.g.@qvac/sdk/llamacpp-completion/plugin), and recommend@qvac/bare-sdkfor direct Bare usage.@qvac/sdkREADME clarifies Bare needs explicit registration;@qvac/bare-sdkREADME adds a "Connection lifecycle" section documentingclose()andunloadModel({ autoClose }).🧪 How was it tested?
bun run bare:exampleon Bare for the affected tests and examples — plugins register and they execute successfully.